[20542] Refactor Github CI sanitizer related jobs #4662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EduPonz
force-pushed
the
ci/refactor_sanitizers
branch
from
a96f890 to
77c793e
Compare
EduPonz
requested review from
JesusPoderoso
and removed request for
JesusPoderoso
EduPonz
force-pushed
the
ci/refactor_sanitizers
branch
3 times, most recently
from
6427c49 to
f0cca47
Compare
EduPonz
force-pushed
the
ci/refactor_sanitizers
branch
11 times, most recently
from
2c2dc06 to
78b0e40
Compare
EduPonz
force-pushed
the
ci/refactor_sanitizers
branch
2 times, most recently
from
f2820b6 to
c98b293
Compare
…tdds Signed-off-by: eduponz <[email protected]>
Signed-off-by: eduponz <[email protected]>
Signed-off-by: eduponz <[email protected]>
…ath is 10 Signed-off-by: eduponz <[email protected]>
Signed-off-by: eduponz <[email protected]>
Signed-off-by: eduponz <[email protected]>
Signed-off-by: eduponz <[email protected]>
Signed-off-by: eduponz <[email protected]>
7 tasks
Signed-off-by: eduponz <[email protected]>
EduPonz
requested review from
JesusPoderoso
and removed request for
JesusPoderoso
|
@Mergifyio backport 2.13.x 2.10.x 2.6.x |
✅ Backports have been created
|
… reporting Signed-off-by: eduponz <[email protected]>
EduPonz
requested review from
JesusPoderoso
and removed request for
JesusPoderoso
JesusPoderoso
suggested changes
Apr 8, 2024
Signed-off-by: eduponz <[email protected]>
JesusPoderoso
approved these changes
Apr 8, 2024
JesusPoderoso
added
ready-to-merge
mergify bot
pushed a commit
that referenced
this pull request
Apr 10, 2024
* Refs #20542: Add Fast DDS Sanitizer worflow with support for asan fastdds Signed-off-by: eduponz <[email protected]> * Refs #20542: Add asan_discovery_server_test job Signed-off-by: eduponz <[email protected]> * Refs #20542: Add tsan_fastdds_test job Signed-off-by: eduponz <[email protected]> * Refs #20542: Remove colcon_meta input as max inputs for workflow_dispath is 10 Signed-off-by: eduponz <[email protected]> * Refs #20542: Create a reusable workflow and a CI one for PRs or manual Signed-off-by: eduponz <[email protected]> * Refs #20542: Add nightly sanitizer CI for all supported branches Signed-off-by: eduponz <[email protected]> * Refs #20542: Change extension to .yml Signed-off-by: eduponz <[email protected]> * Refs #20542: Remove old workflows Signed-off-by: eduponz <[email protected]> * Refs #20542: Run sanitizers CI on PR review request Signed-off-by: eduponz <[email protected]> * Refs #20542: Exclude xfail tests in discovery server test run Signed-off-by: eduponz <[email protected]> * Refs #20542: Install all python packages needed for asan_fastdds_test reporting Signed-off-by: eduponz <[email protected]> * Refs #20542: Apply Jesús' suggestions Signed-off-by: eduponz <[email protected]> --------- Signed-off-by: eduponz <[email protected]> (cherry picked from commit ac0e737) # Conflicts: # .github/workflows/address-sanitizers.yaml # .github/workflows/thread-sanitizer.yaml
mergify bot
pushed a commit
that referenced
this pull request
Apr 10, 2024
* Refs #20542: Add Fast DDS Sanitizer worflow with support for asan fastdds Signed-off-by: eduponz <[email protected]> * Refs #20542: Add asan_discovery_server_test job Signed-off-by: eduponz <[email protected]> * Refs #20542: Add tsan_fastdds_test job Signed-off-by: eduponz <[email protected]> * Refs #20542: Remove colcon_meta input as max inputs for workflow_dispath is 10 Signed-off-by: eduponz <[email protected]> * Refs #20542: Create a reusable workflow and a CI one for PRs or manual Signed-off-by: eduponz <[email protected]> * Refs #20542: Add nightly sanitizer CI for all supported branches Signed-off-by: eduponz <[email protected]> * Refs #20542: Change extension to .yml Signed-off-by: eduponz <[email protected]> * Refs #20542: Remove old workflows Signed-off-by: eduponz <[email protected]> * Refs #20542: Run sanitizers CI on PR review request Signed-off-by: eduponz <[email protected]> * Refs #20542: Exclude xfail tests in discovery server test run Signed-off-by: eduponz <[email protected]> * Refs #20542: Install all python packages needed for asan_fastdds_test reporting Signed-off-by: eduponz <[email protected]> * Refs #20542: Apply Jesús' suggestions Signed-off-by: eduponz <[email protected]> --------- Signed-off-by: eduponz <[email protected]> (cherry picked from commit ac0e737) # Conflicts: # .github/workflows/address-sanitizers.yaml # .github/workflows/config/asan_colcon.meta # .github/workflows/thread-sanitizer.yaml
mergify bot
pushed a commit
that referenced
this pull request
Apr 10, 2024
* Refs #20542: Add Fast DDS Sanitizer worflow with support for asan fastdds Signed-off-by: eduponz <[email protected]> * Refs #20542: Add asan_discovery_server_test job Signed-off-by: eduponz <[email protected]> * Refs #20542: Add tsan_fastdds_test job Signed-off-by: eduponz <[email protected]> * Refs #20542: Remove colcon_meta input as max inputs for workflow_dispath is 10 Signed-off-by: eduponz <[email protected]> * Refs #20542: Create a reusable workflow and a CI one for PRs or manual Signed-off-by: eduponz <[email protected]> * Refs #20542: Add nightly sanitizer CI for all supported branches Signed-off-by: eduponz <[email protected]> * Refs #20542: Change extension to .yml Signed-off-by: eduponz <[email protected]> * Refs #20542: Remove old workflows Signed-off-by: eduponz <[email protected]> * Refs #20542: Run sanitizers CI on PR review request Signed-off-by: eduponz <[email protected]> * Refs #20542: Exclude xfail tests in discovery server test run Signed-off-by: eduponz <[email protected]> * Refs #20542: Install all python packages needed for asan_fastdds_test reporting Signed-off-by: eduponz <[email protected]> * Refs #20542: Apply Jesús' suggestions Signed-off-by: eduponz <[email protected]> --------- Signed-off-by: eduponz <[email protected]> (cherry picked from commit ac0e737) # Conflicts: # .github/workflows/address-sanitizers.yaml # .github/workflows/config/asan_colcon.meta # .github/workflows/thread-sanitizer.yaml
This was referenced Apr 10, 2024
JesusPoderoso
pushed a commit
that referenced
this pull request
Apr 10, 2024
* Refs #20542: Add Fast DDS Sanitizer worflow with support for asan fastdds Signed-off-by: eduponz <[email protected]> * Refs #20542: Add asan_discovery_server_test job Signed-off-by: eduponz <[email protected]> * Refs #20542: Add tsan_fastdds_test job Signed-off-by: eduponz <[email protected]> * Refs #20542: Remove colcon_meta input as max inputs for workflow_dispath is 10 Signed-off-by: eduponz <[email protected]> * Refs #20542: Create a reusable workflow and a CI one for PRs or manual Signed-off-by: eduponz <[email protected]> * Refs #20542: Add nightly sanitizer CI for all supported branches Signed-off-by: eduponz <[email protected]> * Refs #20542: Change extension to .yml Signed-off-by: eduponz <[email protected]> * Refs #20542: Remove old workflows Signed-off-by: eduponz <[email protected]> * Refs #20542: Run sanitizers CI on PR review request Signed-off-by: eduponz <[email protected]> * Refs #20542: Exclude xfail tests in discovery server test run Signed-off-by: eduponz <[email protected]> * Refs #20542: Install all python packages needed for asan_fastdds_test reporting Signed-off-by: eduponz <[email protected]> * Refs #20542: Apply Jesús' suggestions Signed-off-by: eduponz <[email protected]> --------- Signed-off-by: eduponz <[email protected]> (cherry picked from commit ac0e737)
EduPonz
added a commit
that referenced
this pull request
Apr 17, 2024
* Refactor Github CI sanitizer related jobs (#4662) * Refs #20542: Add Fast DDS Sanitizer worflow with support for asan fastdds Signed-off-by: eduponz <[email protected]> * Refs #20542: Add asan_discovery_server_test job Signed-off-by: eduponz <[email protected]> * Refs #20542: Add tsan_fastdds_test job Signed-off-by: eduponz <[email protected]> * Refs #20542: Remove colcon_meta input as max inputs for workflow_dispath is 10 Signed-off-by: eduponz <[email protected]> * Refs #20542: Create a reusable workflow and a CI one for PRs or manual Signed-off-by: eduponz <[email protected]> * Refs #20542: Add nightly sanitizer CI for all supported branches Signed-off-by: eduponz <[email protected]> * Refs #20542: Change extension to .yml Signed-off-by: eduponz <[email protected]> * Refs #20542: Remove old workflows Signed-off-by: eduponz <[email protected]> * Refs #20542: Run sanitizers CI on PR review request Signed-off-by: eduponz <[email protected]> * Refs #20542: Exclude xfail tests in discovery server test run Signed-off-by: eduponz <[email protected]> * Refs #20542: Install all python packages needed for asan_fastdds_test reporting Signed-off-by: eduponz <[email protected]> * Refs #20542: Apply Jesús' suggestions Signed-off-by: eduponz <[email protected]> --------- Signed-off-by: eduponz <[email protected]> (cherry picked from commit ac0e737) # Conflicts: # .github/workflows/address-sanitizers.yaml # .github/workflows/config/asan_colcon.meta # .github/workflows/thread-sanitizer.yaml * Refs #20703: Fix conflicts Signed-off-by: Mario Dominguez <[email protected]> * Refs #20703: Remove sanitizer nightlies Signed-off-by: Mario Dominguez <[email protected]> * Refs #20703: Remove old sanitizer jobs Signed-off-by: Mario Dominguez <[email protected]> * Refs #20703: set default discovery server branch to v1.2.1 Signed-off-by: Mario Dominguez <[email protected]> * #20703: Address review changes Signed-off-by: Mario Dominguez <[email protected]> --------- Signed-off-by: Mario Dominguez <[email protected]> Co-authored-by: Eduardo Ponz Segrelles <[email protected]> Co-authored-by: Mario Dominguez <[email protected]>
EduPonz
added a commit
that referenced
this pull request
Apr 18, 2024
* Refs #20542: Add Fast DDS Sanitizer worflow with support for asan fastdds Signed-off-by: eduponz <[email protected]> * Refs #20542: Add asan_discovery_server_test job Signed-off-by: eduponz <[email protected]> * Refs #20542: Add tsan_fastdds_test job Signed-off-by: eduponz <[email protected]> * Refs #20542: Remove colcon_meta input as max inputs for workflow_dispath is 10 Signed-off-by: eduponz <[email protected]> * Refs #20542: Create a reusable workflow and a CI one for PRs or manual Signed-off-by: eduponz <[email protected]> * Refs #20542: Add nightly sanitizer CI for all supported branches Signed-off-by: eduponz <[email protected]> * Refs #20542: Change extension to .yml Signed-off-by: eduponz <[email protected]> * Refs #20542: Remove old workflows Signed-off-by: eduponz <[email protected]> * Refs #20542: Run sanitizers CI on PR review request Signed-off-by: eduponz <[email protected]> * Refs #20542: Exclude xfail tests in discovery server test run Signed-off-by: eduponz <[email protected]> * Refs #20542: Install all python packages needed for asan_fastdds_test reporting Signed-off-by: eduponz <[email protected]> * Refs #20542: Apply Jesús' suggestions Signed-off-by: eduponz <[email protected]> --------- Signed-off-by: eduponz <[email protected]> (cherry picked from commit ac0e737) Co-authored-by: Eduardo Ponz Segrelles <[email protected]>
EduPonz
added a commit
that referenced
this pull request
Apr 18, 2024
* Refactor Github CI sanitizer related jobs (#4662) * Refs #20542: Add Fast DDS Sanitizer worflow with support for asan fastdds Signed-off-by: eduponz <[email protected]> * Refs #20542: Add asan_discovery_server_test job Signed-off-by: eduponz <[email protected]> * Refs #20542: Add tsan_fastdds_test job Signed-off-by: eduponz <[email protected]> * Refs #20542: Remove colcon_meta input as max inputs for workflow_dispath is 10 Signed-off-by: eduponz <[email protected]> * Refs #20542: Create a reusable workflow and a CI one for PRs or manual Signed-off-by: eduponz <[email protected]> * Refs #20542: Add nightly sanitizer CI for all supported branches Signed-off-by: eduponz <[email protected]> * Refs #20542: Change extension to .yml Signed-off-by: eduponz <[email protected]> * Refs #20542: Remove old workflows Signed-off-by: eduponz <[email protected]> * Refs #20542: Run sanitizers CI on PR review request Signed-off-by: eduponz <[email protected]> * Refs #20542: Exclude xfail tests in discovery server test run Signed-off-by: eduponz <[email protected]> * Refs #20542: Install all python packages needed for asan_fastdds_test reporting Signed-off-by: eduponz <[email protected]> * Refs #20542: Apply Jesús' suggestions Signed-off-by: eduponz <[email protected]> --------- Signed-off-by: eduponz <[email protected]> (cherry picked from commit ac0e737) # Conflicts: # .github/workflows/address-sanitizers.yaml # .github/workflows/config/asan_colcon.meta # .github/workflows/thread-sanitizer.yaml * Fix conflicts Signed-off-by: JesusPoderoso <[email protected]> --------- Signed-off-by: JesusPoderoso <[email protected]> Co-authored-by: Eduardo Ponz Segrelles <[email protected]> Co-authored-by: JesusPoderoso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the Github CI for Address and Thread Sanitizers. It removes the old workflows and adds a single reusable one that defines 4 jobs:
asan_fastdds_buildasan_fastdds_test(uses the build fromasan_fastdds_build)asan_discovery_server_test(uses the build fromasan_fastdds_build)tsan_fastdds_testFurthermore, it adds both a
sanitizers-ci.yamlandnightly-sanitizers-ci.yamlso that:no-testandskip-cilabels are not set.asan_fastdds_test,asan_discovery_server_test, andtsan_fastdds_test. This way it is possible to run a subset of the jobs defined in the workflow.address_sanitizers.yamlthread_sanitizer.yaml@Mergifyio backport 2.13.x 2.10.x 2.6.x
IMPORTANT: Remove the nightly workflows from the backports, as they will not run anyways.
Contributor Checklist
versions.mdfile (if applicable).Reviewer Checklist